[LA.pm] Parallel::Simple

[James Keenan]

On Feb 26, 2005, at 3:33 AM, Kevin Scaldeferri wrote:

> On Feb 25, 2005, at 9:31 PM, Ofer Nave wrote:
>
>>
>> I just finished coding, testing, and documenting a module that I've
>> written for CPAN.  I wanted to get some feedback here on it before I
>> upload it.
>>
>> This is my first CPAN module ever, so please feel free to tear it 
>> apart.
>> I'll take feedback on anything - design, code style, pod style, doc
>> effectiveness, and especially bugs.
>>
>
> First, I think it's almost always good to 'use warnings'.
>
> You probably ought to initialize $error and $return_values.  Otherwise 
> you might have some problems if someone did something odd like 
> run()ing no processes then checking the results.  You might also want 
> to explicitly reset those globals at the start of run() as well.
>
> For that matter, there may be some other things that don't work out 
> right if the number of code refs to run is 0.
>
> I also have an objection to the terminology you are using in the code 
> and documentation.  You refer to "blocks" when I think that you really 
> mean "code references".
>

I agree on all points.

>
>> After some polishing up, I'll write some tests for it and package it 
>> up in
>> the standard CPAN module format before uploading it.
>
>

I would add that testing is particularly important in this case because 
of the considerable number of system calls which the module inherently 
does.