[Chicago-talk] Script comments

Young, Darren Darren.Young at ChicagoGSB.edu
Tue Jan 17 12:05:32 PST 2006


> 1.  Pod::Usage - live it, learn it, love it.

Yea, good idea, that's another chunk that was supposed to be 2 options
and was added at the start but has grown out of control now.

> 2.  I saw you were using POSIX::strftime() one place in your script.
>     So why do you have this code in there too. 

You know, I completely missed that one, thanks.

> Also, do you really want to fail your backup if someone writes out an
empty log message.

Probably not, the logmsg is pulled from a logging package I normally use
and was still there.

> 3.  Why is your program have its own unique logging function? 
>  A package would probably be more useful, and let you put all your
logs
>  in a single parsable format.

It actually is in another package that I normally use. I just ripped
that function out for this script. Not enough time to think this one
through.


More information about the Chicago-talk mailing list