<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:tahoma, new york, times, serif;font-size:12pt"><DIV></DIV>
<DIV>Mr. Sweger,</DIV>
<DIV> </DIV>
<DIV>I'm no expert, but it seems to me that Mr. Krahn's comments are all perfectly valid, and I can detect no ill intent, or slander towards the original poster. His are the types of comments to be expected during a professional code review. Were these directed at code I had written, I would welcome them rather than take them personally.<BR> </DIV>---<BR>Mark Mertel<BR>
<DIV><BR></DIV>
<DIV style="FONT-SIZE: 12pt; FONT-FAMILY: tahoma, new york, times, serif"><BR>
<DIV style="FONT-SIZE: 10pt; FONT-FAMILY: arial, helvetica, sans-serif"><FONT face=Tahoma size=2>
<HR SIZE=1>
<B><SPAN style="FONT-WEIGHT: bold">From:</SPAN></B> Andrew Sweger <andrew@sweger.net><BR><B><SPAN style="FONT-WEIGHT: bold">To:</SPAN></B> John W. Krahn <jwkrahn@shaw.ca><BR><B><SPAN style="FONT-WEIGHT: bold">Cc:</SPAN></B> SPUG <spug-list@mail.pm.org><BR><B><SPAN style="FONT-WEIGHT: bold">Sent:</SPAN></B> Wednesday, February 25, 2009 8:55:13 AM<BR><B><SPAN style="FONT-WEIGHT: bold">Subject:</SPAN></B> Re: SPUG: Regexp::Assemble question<BR></FONT><BR>On Tue, 24 Feb 2009, John W. Krahn wrote:<BR><BR>> Emails do not have colours, they are just plain text.<BR><BR>Mine doesn't. But I know some do. Regardless, Amit's intent was still<BR>understood. <BR><BR>> Is this your actual code? If so, you don't need the subroutines at all, <BR>> you just need the keys. And why use a hash reference instead of a hash?<BR><BR>Your tone suggests that all Perl programmers should use it in the same way<BR>(your's aparently). Where I
come from, Perl is spoken by people of every<BR>skill level; from baby-perl-talk to uber-l33t-golpher-perl. If the code<BR>works, it works. Style and convention mostly become a matter of teamwork.<BR>This list is about learning and sharing Perl. I suspect you might not have<BR>realized this (considering your reply to Amit and your previous reply to<BR>this list).<BR><BR>> Why all the duplicate code?<BR>> <BR>> my $mode = qx(file $filename) =~ /gzip/i ? '<:gzip' : '<';<BR>> open MYINPUTFILE, $mode, $filename or $Logger->logdie( "Error <BR>> opening file: $!" );<BR><BR>Again, TIMTOWTDI.<BR><BR>> No need for this variable as Perl provides the $. built-in variable that <BR>> keeps track of the current line number.<BR><BR>Maybe so, but $lines is a lot more obvious than $. when it comes time to<BR>review or update the code. Perhaps $INPUT_LINE_NUMBER (via <A href="http://english.pm/"
target=_blank>English.pm</A>)<BR>could be even more obvious (and mean *exactly* the same thing as $.,<BR>whereas $lines could actually mean something slightly different!).<BR><BR>> Those people who think they know everything are a great<BR>> annoyance to those of us who do. -- Isaac Asimov<BR><BR>Wow. Again?<BR><BR>Let me put it simply: knock it off. If you want to bash people about how<BR>they write Perl, go hang out on Usenet or some obscure IRC channel. It's<BR>not welcome here.<BR><BR>-- <BR>Andrew B. Sweger -- The great thing about multitasking is that several<BR> things can go wrong at once.<BR><BR><BR><BR><BR><BR>_____________________________________________________________<BR>Seattle Perl Users Group Mailing List<BR> POST TO: <A href="mailto:spug-list@pm.org"
ymailto="mailto:spug-list@pm.org">spug-list@pm.org</A><BR>SUBSCRIPTION: http://mail.pm.org/mailman/listinfo/spug-list<BR> MEETINGS: 3rd Tuesdays<BR> WEB PAGE: http://seattleperl.org/<BR></DIV></DIV></div><br>
</body></html>