If you really want to use require you have to declare the variables in your main script first with 'our' like this:<div><br></div><div>our ($var1, $var2, $var3);</div><div>require $configfile;</div><div># now $var1, etc will have whatever values were set in the config file</div>
<meta charset="utf-8"><div><br></div><div>However, I hesitate to even point that out since logic in the config file is probably a bad idea as was pointed out. If you're hash of all possible options is not super big (megabytes) I'd just go that route and not worry about the memory. You may be optimizing prematurely.</div>
<div><br></div><div>Trevor<br><br><div class="gmail_quote">On Tue, Feb 22, 2011 at 2:50 AM, John Ricker <span dir="ltr"><<a href="mailto:sephtin%2Bpm-talk@gmail.com">sephtin+pm-talk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5"><div class="gmail_quote">On Tue, Feb 22, 2011 at 2:08 AM, Mike South <span dir="ltr"><<a href="mailto:msouth@gmail.com" target="_blank">msouth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div><div></div><div>On Mon, Feb 21, 2011 at 10:21 PM, John Ricker <span dir="ltr"><<a href="mailto:sephtin@gmail.com" target="_blank">sephtin@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Just having converted a bash script to Perl, ran across a couple issues, and thought maybe sending to the list might obtain a nudge in the right direction.. :)<div><br></div><div>The issue I'm currently trying to tackle is pulling in config info.</div>
<div>I have a config information I want to include, but it's dependent on a variable(s) set in my script. In bash, I'd just source the file, and it'd go through the if statements, and all is well. In Perl, I can't seem to tackle it...</div>
<div><br></div><div>Example:</div><div>#<a href="http://main.pl" target="_blank">main.pl</a></div><div>if (stuff) {</div><div> $varsneeded = "first";</div><div>}</div><div>elsif (otherstuff) {</div><div> $varsneeded = "second";</div>
<div>}</div><div>else {</div><div> $varsneeded = "last";</div><div>}</div><div><br></div><div><need to read in variables here></div><div><then do stuff with variables></div><div><br></div><div>---x---</div>
<div>#configFile:</div><div>if ($varsneeded eq "first") {</div><div> $var1 = "1";</div><div> $var2 = "2";</div><div> ...</div><div>}</div><div>elseif ($varsneeded eq "second") {</div>
<div> $var1 = "somethingelse1";</div><div> $var2 = "somethingelse2";</div><div> ...</div><div>}</div><div><br></div><div>You get the idea.</div><div><br></div><div>So, I've tried:</div><div>
--use: Did testing with use, and thought it was my answer, but unfortunately the directory that I need to grab the config file(s) from is set from a variable... which isn't defined until after compile time, so use doesn't seem to be an option.</div>
<div>--do/require: Can't seem to find a way to pass the $varsneeded variable into the config file(s) (.pl, .pm, .whatever) when using do or require. If there's an example out there of this, then somehow google has not been kind enough to enlighten me. :P</div>
<div>--eval `config file`: variable to the config file, same issue as do/require attempts.</div><div><br></div><div>Obviously I've oversimplified the example. The script is over 1200 lines, so simplified for good reason. Looking for best practice kind of thing here.. if more detail is needed (I expect it may come to that).. I can fill in a lot of blanks, just need to know what info might be helpful.</div>
<div><br></div><div>More info--</div><div>After some thought, and after re-reading my question.. thought some additional info might be helpful.</div><div><br></div><div>The script is for creating custom themes. I'm taking choices made on a php page that are passed to the script, and the script is pulling in variables based on those choices... and some other factors.. :P</div>
<div>Each section is approx. 26 variables right now, and there are 19 different possible options with another dozen or two coming soon.</div><div><br></div><div>MY answer to this all, is to break up the config file into a file for each option, and just pull in the appropriate file... But as this beast grows, I'd REALLY like the convenience of a find/replace in ONE file when something changes, instead of 50 or more!</div>
</blockquote><div><br></div></div></div><div>I don't understand what you're saying here--do you mean that you would like all the configuration to be in one file?</div><div><br></div><div>You could have one single perl data structure with all the data:</div>
<div><br></div><div><font face="'courier new', monospace">my $config={</font></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> theme1=>{</font></div><div style="font-family:arial"><font face="'courier new', monospace"> option1=>{ </font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> var1=>'theme1option1var1', </font></div><div style="font-family:arial"><div><font face="'courier new', monospace"> var2=>'theme1option1var2', </font></div>
</div><div><font face="'courier new', monospace"><div style="font-family:arial"><font face="'courier new', monospace"> var3=>'theme1option1var3', </font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> },</font></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> option2=>{ </font></div><div style="font-family:arial"><font face="'courier new', monospace"> var1=>'theme1option2var1', </font></div>
<div style="font-family:arial"><div><font face="'courier new', monospace"> var2=>'theme1option2var2', </font></div></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> var3=>'theme1option2var3', </font></div><div style="font-family:arial"><font face="'courier new', monospace"> },</font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> },</font></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> theme2=>{</font></div><div style="font-family:arial"><font face="'courier new', monospace"> option1=>{ </font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> var1=>'theme2option1var1', </font></div><div style="font-family:arial"><div><font face="'courier new', monospace"> var2=>'theme2option1var2', </font></div>
</div><div><font face="'courier new', monospace"><div style="font-family:arial"><font face="'courier new', monospace"> var3=>'theme2option1var3', </font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> },</font></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> option2=>{ </font></div><div style="font-family:arial"><font face="'courier new', monospace"> var1=>'theme2option2var1', </font></div>
<div style="font-family:arial"><div><font face="'courier new', monospace"> var2=>'theme2option2var2', </font></div></div><div><font face="'courier new', monospace"><div style="font-family:arial">
<font face="'courier new', monospace"> var3=>'theme2option2var3', </font></div><div style="font-family:arial"><font face="'courier new', monospace"> },</font></div>
<div style="font-family:arial"><font face="'courier new', monospace"> },</font></div><div>};</div><div><br></div><div>my $theme_choice = shift;</div><div>my $option_choice = shift;</div>
<div>my $theme_key = 'theme'.$theme_choice;</div><div>my $option_key = 'option'.$option_choice;</div><div><br></div><div>my $config_to_use = $config->{$theme_key}{$option_key};</div><div><br></div><div>
foreach my $var_name (qw/var1 var2 var3/) {</div><div> print "var1: $config_to_use->{$var_name}\n";</div><div>} </div></font></div></font></div></font></div></font></div></font></div></font></div></font></div>
</font></div><div><div><br></div><div>msmbp:~ msouth$ perl <a href="http://glurg.pl" target="_blank">glurg.pl</a> 1 a</div><div>var1: theme1,optiona,var1</div><div>var1: theme1,optiona,var2</div><div>var1: theme1,optiona,var3</div>
<div>msmbp:~ msouth$ perl <a href="http://glurg.pl" target="_blank">glurg.pl</a> 2 b</div>
<div>var1: theme2,optionb,var1</div><div>var1: theme2,optionb,var2</div><div>var1: theme2,optionb,var3</div></div><div><br></div><div>That would give you one config file to edit.</div><div><br></div><div>If you want to do it per your original description, bash-ish-ly (I don't recommend this), below is how (I used the environment (accessed via %ENV) to simulate data coming in that you don't know until runtime--should have used "shift" to make it easier). There are some techniques (requiring a file you didn't know the location of until runtime, sharing a variable via "our") that might be of interest.</div>
<div><br></div><div>mike</div><div><br></div><div><div><font face="'courier new', monospace">msmbp:~ msouth$ cat <a href="http://bob.pl" target="_blank">bob.pl</a></font></div><div><font face="'courier new', monospace">use strict;</font></div>
<div><font face="'courier new', monospace">use warnings;</font></div><div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">our $which_config;</font></div>
<div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">our $var1;</font></div><div><font face="'courier new', monospace"><br>
</font></div><div><font face="'courier new', monospace">our $which_dir = 'bob';</font></div><div><font face="'courier new', monospace"><br></font></div>
<div><font face="'courier new', monospace">$which_config = 'one';</font></div><div><font face="'courier new', monospace">#$which_config = 'two';</font></div>
<div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">my $theme_sub_dir = $ENV{theme} || die "set theme in the env like this: theme='test' $0\n";</font></div>
<div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">my $full_path_to_require = "/Users/msouth/$theme_sub_dir";</font></div>
<div><font face="'courier new', monospace">die "there is not a directory called $full_path_to_require" unless -d $full_path_to_require;</font></div><div><font face="'courier new', monospace">push @INC, $full_path_to_require;;</font></div>
<div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">require "$which_dir/<a href="http://set_up_bob.pl" target="_blank">set_up_bob.pl</a>";</font></div>
<div><font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">print $var1,$/;</font></div><div><font face="'courier new', monospace">msmbp:~ msouth$ cat bob/<a href="http://set_up_bob.pl" target="_blank">set_up_bob.pl</a></font></div>
<div><font face="'courier new', monospace">use strict;</font></div><div><font face="'courier new', monospace">use warnings;</font></div><div><font face="'courier new', monospace"><br>
</font></div><div><font face="'courier new', monospace">our $which_config;</font></div><div><font face="'courier new', monospace">our $var1;</font></div><div>
<font face="'courier new', monospace"><br></font></div><div><font face="'courier new', monospace">if ($which_config eq 'one') {</font></div><div><font face="'courier new', monospace"> $var1='the one version of var1';</font></div>
<div><font face="'courier new', monospace">}</font></div><div><font face="'courier new', monospace">elsif ($which_config eq 'two' ) {</font></div><div>
<font face="'courier new', monospace"> $var1='the two version of var1';</font></div><div><font face="'courier new', monospace">}</font></div><div>
<font face="'courier new', monospace">else {</font></div><div><font face="'courier new', monospace"> die "you didn't tell me which config in the 'which_config' variable, or maybe you didn't declare it with 'our'";</font></div>
<div><font face="'courier new', monospace">}</font></div><div><font face="'courier new', monospace">msmbp:~ msouth$ theme=bob perl <a href="http://bob.pl" target="_blank">bob.pl</a></font></div>
<div><font face="'courier new', monospace">the one version of var1</font></div></div><div><br></div></div>
</blockquote></div><br></div></div><div><div>After seeing both of you (Matt/Mike) suggesting the same thing.. I may need to revisit a config file that just loads everything (hash most likely), but wouldn't that keep everything in memory? (While maybe not that much memory... but it would add up.. no?).</div>
<div>I guess I assumed that the "cleaner" way to do it, was to only load the variables I was going to use, while ignoring those that I'm not interested in... I'm fairly new to Perl, so clueless about best practices.</div>
<div><br></div><div>Re: the "bash'ish" way... was the only way I could come up with that didn't load everything regardless of what I needed... other than splitting up each theme into separate files, which I'm trying to avoid.</div>
<div>My failure was with use(), since it required path at runtime (using lib) which I couldn't provide at compile time as the path is a variable defined in the file.</div><div>I DID attempt require, but wasn't able to pass the variable to the config file. I must have been doing something wrong because after checking Mike's example and switching things back for require, it seems to be working... I'll probably comment it out, and try what seems to be the most recommended method... just hashing everything, and reading it that way... good learning experience at the very least... :)</div>
<div><br></div><div>Thanks for the quick feedback. Have somewhere to start from at least...</div><div><br></div><font color="#888888"><div>-John</div></font></div>
<br>_______________________________________________<br>
Raleigh-talk mailing list<br>
<a href="mailto:Raleigh-talk@pm.org">Raleigh-talk@pm.org</a><br>
<a href="http://mail.pm.org/mailman/listinfo/raleigh-talk" target="_blank">http://mail.pm.org/mailman/listinfo/raleigh-talk</a><br>
<br></blockquote></div><br></div>