Final update before I hit the sack<br><br>It is now called App:PPBuild. its version is 0.03, the exported functions are lowercase, I have applied some patches from Jacob that help with project management, and I have applied fixes after the advice from Shlomi Fish.<br>
<br>This feedback has been amazing, and very helpful so far, thank you to everyone, please keep it comming :-)<br><br>The git to use for this is:<br><br>git clone ssh://<a href="http://anonymous@open-exodus.net/server/git/ppbuild">anonymous@open-exodus.net/server/git/ppbuild</a><br>
password: anonymous<br><br>At Jacobs advice I will be looking into gitosis to improve ym git server, but that will come later.<br><br>Thanks again everyone.<br><br>-Chad<br><br><div class="gmail_quote">On Sun, Dec 21, 2008 at 1:02 AM, Chad Granum <span dir="ltr"><<a href="mailto:exodist7@gmail.com">exodist7@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="Wj3C7c"><div class="gmail_quote"><br>Thanks for the feedback, I have a few questions:<br>
<br><div class="gmail_quote"><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
1. Why doesn't the distribution have a version? The only thing that has a<br>
version is the module which is versioned at 1.00.<br>
</blockquote></div><div><br>By distribution do you mean the file name? I noticed that after the upload I was not thinking, the second upload had the version number.<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
2. Now why did you version it at 1.00 right away? That's not such a good idea<br>
for open-source software:<br>
<br>
<a href="http://catb.org/esr/writings/cathedral-bazaar/homesteading/ar01s13.html" target="_blank">http://catb.org/esr/writings/cathedral-bazaar/homesteading/ar01s13.html</a><br>
<br>
You should have started at 0.01 or something.<br>
</blockquote></div><div><br>oops, too late now.<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
3. That put aside, I also dislike the fact that it's called "PPBS" rather<br>
than "Build::PPBS" or "App::PPBS" or whatever.<br>
</blockquote></div><div><br>I am actually calling it ppbuild because something similar, but much different from what I need called pbs exists, that author contacted me.<br><br>Would it be worth it at this point to rename it to App::PPBuilder and reversion it to 0.01, or would that just be too much being a third delete/upload change?<br>
</div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
4. The copyright paragraph for the module reads:<br>
<br>
{{{{{{{{{{{<br>
Copyright 2008 Chad Granum<br>
<br>
You should have received a copy of the GNU General Public License along with<br>
this. If not, see <<a href="http://www.gnu.org/licenses/" target="_blank">http://www.gnu.org/licenses/</a>>.<br>
}}}}}}}}}}}<br>
<br>
That's not enough. You should say that it is licensed under the GPL and which<br>
versions exactly.<br>
</blockquote></div><div><br>Will do, Inexperience bit me.<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
5. You're exporting functions that start with an uppercase letter. The Perl<br>
convention (and good practice) is for them to start with a lowercase letter.<br>
</blockquote></div><div><br>I made them capital specifically in this place because it seemed more approptiate to me, is this not a design choice I should make?<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
6. The synopsis lacks a semi-colon after the sub { ... }<br>
<br>
7.<br>
<br>
{{{<br>
File "MyFile, qw/ MyTask /, "touch MyFile";<br>
}}}<br>
<br>
You're missing a double-quotes.<br>
</blockquote></div><div><br>Will fix, thank you.<br> </div></div><br><br>-Chad<br>
</div><br>
</div></div></blockquote></div><br>